current tor git fails to compile

[cypherpunks]

current git compile fail on centos 5.9:

src/test/test.c: In function ‘test_onion_queues’:
src/test/test.c:412: error: ‘NTOR_ONIONSKIN_LEN’ undeclared (first use in this function)
src/test/test.c:412: error: (Each undeclared identifier is reported only once
src/test/test.c:412: error: for each function it appears in.)
src/test/test.c:412: warning: unused variable ‘buf2’
make[1]: * [src/test/src_test_test-test.o] Error 1
make[1]: Leaving directory `/root/Tor/tor'
make: * [all] Error 2

this is with --disable-curve25519 since tor git fails to compile on centos 5.9 with other error without that

[arma]

Nick, this might be an 0.2.4 bug too.

I never quite sorted out the relationship between all the various ways to indicate having or not having ntor support. And I guess it shows in my unit tests. It might also show in my other patches.

[nickm]

What errors do you get with --disable-curvee25519? Those should probably be in another ticket.

[nickm]

Replying to nickm:

What errors do you get with --disable-curvee25519? Those should probably be in another ticket.

Ah, never mind. That's #9699.

[nickm]

0.2.4 still builds fine with --disable-curve25519; the tests are what needs the fix. Half a mo... There. Fixed in a0a855d586d99540277014ccd3.

[blueness]

We're still hitting this with 0.2.4.21 in Gentoo. See the downstream bug:

​https://bugs.gentoo.org/show_bug.cgi?id=505174

[nickm]

Backported the fixed to 0.2.4.x as a83abcf5ee5cb8fe245bc97e089e082f62921194. I'd ordinarily ask for more review, but this is just moving an #include in a unit test file.